fix: add env.error shim for yeoman-environment v4 backwards compatibility - #76
Merged
Merged
Conversation
…lity Agent-Logs-Url: https://github.com/adobe/aio-cli-plugin-app-templates/sessions/88d0d448-da78-468e-9f8c-0e31e0c5c27b Co-authored-by: shazron <36107+shazron@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix TypeError when instantiating ActionGenerator
fix: add env.error shim for yeoman-environment v4 backwards compatibility
Apr 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
shazron
marked this pull request as ready for review
April 27, 2026 10:19
shazron
approved these changes
Apr 27, 2026
purplecabbage
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #75
yeoman-environment v4 removed the
env.error()method present in v3. Generators like@adobe/generator-app-common-lib'sActionGeneratorcallthis.env.error()in their constructors, producingTypeError: this.env.error is not a functioninstead of the intended error message.Changes
src/commands/templates/install.js— Afteryeoman.createEnv(), conditionally attach anenv.errorshim that mirrors the v3 behaviour:The guard means the shim is a no-op if a future yeoman-environment version restores the method.
test/commands/templates/install.test.jsbeforeEachnow deletescreateEnvReturnValue.errorto prevent shim state from leaking across tests.Errorinstance).error.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
scarf.sh/usr/local/bin/node node ./report.js(dns block)If you need me to access, download, or install something from one of these locations, you can either: